Added ability to change audio drivers without restarting #31082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
from
71c3906 to
5eeffe3
Compare
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
2 times, most recently
from
267fffd to
3d0cb95
Compare
| set(AUDIO_DRIVER_SRC | ||
| #${CMAKE_CURRENT_LIST_DIR}/platform/win/winmmdriver.cpp | ||
| #${CMAKE_CURRENT_LIST_DIR}/platform/win/winmmdriver.h | ||
| #${CMAKE_CURRENT_LIST_DIR}/platform/win/wincoreaudiodriver.cpp |
Contributor
There was a problem hiding this comment.
What do you think about removing winmmdriver and wincoreaudiodriver? Their implementation is extremely outdated at this point
RomanPudashkin
approved these changes
Nov 18, 2025
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
4 times, most recently
from
b4adbd1 to
ad1ff6d
Compare
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
from
ad1ff6d to
edd9fea
Compare
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
from
edd9fea to
7fc596a
Compare
igorkorsukov
force-pushed
the
w/audio/change_api_norestart_2
branch
2 times, most recently
from
0df9681 to
259e762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.